Move the code that extends the prediction to Renderer #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
approved these changes
Sep 19, 2017
|
The number of steps of the target prediction does not appear to be set correctly when changing that of the active vessel. |
eggrobin
approved these changes
Sep 21, 2017
ksp_plugin/plugin.cpp
Outdated
| prediction_adaptive_step_parameters) const { | ||
| // If there is a target vessel, it is integrated with the same parameters as | ||
| // the given (current) vessel. This makes it possible to plot things like the | ||
| // closest approaches. |
There was a problem hiding this comment.
To plot the prediction of the current vessel, markers are just a special case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed when investigating #1561 (the new test show a case where we evaluate the prediction after its last point) but this is really unrelated because #1561 is about evaluating the prediction before its first point.
Also making
Vessel::UpdatePredictionidempotent for performance.